New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cookie-pick feature #1133
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1133 +/- ##
======================================
Coverage 100% 100%
======================================
Files 18 19 +1
Lines 783 843 +60
======================================
+ Hits 783 843 +60
Continue to review full report at Codecov.
|
1c3c6c8
to
8dcdbe6
Compare
8dcdbe6
to
29f0ccb
Compare
Closing this for several reasons: outdated, never got attention from anyone and maybe the most important aspect: it does not solve an existing bug or feature request. By having a bried look at this change I say "that is a lot of code added for something that looks like a corner case". If you really want this to happen, you should better start with a feature request that describes very well the use case. If it manages to get the buy-in from few others, it worth creating a PR to fix it. |
Maybe the look was too brief. The PR solves the linked feature request #1134. On top of that the added documentation gives details about the use case. That being said, I'm just interested in the functionality to go into cookiecutter. So I'll leave it to the newer PR. |
@nalch I know, the project lacked active maintenance for a very long time but hopefully this we are going to revive its community. Few months ago I was ready to scrap it from other projects where I was using due to this but recently I become core and I can help a little bit keeping it afloat. As you mentioned the original feature request, I added it to the description and also added a comment there. I will also reopen this until we can make a decision. |
No worries. Let's take the newer pull request instead to get the functionality in. |
TODO: Put description here
Fixes: #1134