Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cookie-pick feature #1133

Closed
wants to merge 1 commit into from

Conversation

nalch
Copy link

@nalch nalch commented Dec 28, 2018

TODO: Put description here

Fixes: #1134

@codecov-io
Copy link

codecov-io commented Dec 28, 2018

Codecov Report

Merging #1133 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1133   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          18      19    +1     
  Lines         783     843   +60     
======================================
+ Hits          783     843   +60
Impacted Files Coverage Δ
cookiecutter/cookie_pick.py 100% <100%> (ø)
cookiecutter/main.py 100% <100%> (ø) ⬆️
cookiecutter/cli.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db14e06...29f0ccb. Read the comment docs.

@nalch nalch mentioned this pull request Dec 28, 2018
@insspb insspb added the 1.8.0 label Dec 22, 2019
@insspb insspb added this to In progress in 1.8.0 Release via automation Dec 22, 2019
@ssbarnea
Copy link
Member

Closing this for several reasons: outdated, never got attention from anyone and maybe the most important aspect: it does not solve an existing bug or feature request. By having a bried look at this change I say "that is a lot of code added for something that looks like a corner case".

If you really want this to happen, you should better start with a feature request that describes very well the use case. If it manages to get the buy-in from few others, it worth creating a PR to fix it.

@ssbarnea ssbarnea closed this Jan 18, 2020
1.8.0 Release automation moved this from In progress to Done Jan 18, 2020
@nalch
Copy link
Author

nalch commented Jan 18, 2020

Maybe the look was too brief. The PR solves the linked feature request #1134. On top of that the added documentation gives details about the use case.
This exact use case of migrating cookiecutter changes came up again and again over the years (f.e. #784 and #1173).

That being said, I'm just interested in the functionality to go into cookiecutter. So I'll leave it to the newer PR.

@ssbarnea
Copy link
Member

@nalch I know, the project lacked active maintenance for a very long time but hopefully this we are going to revive its community. Few months ago I was ready to scrap it from other projects where I was using due to this but recently I become core and I can help a little bit keeping it afloat.

As you mentioned the original feature request, I added it to the description and also added a comment there. I will also reopen this until we can make a decision.

@ssbarnea ssbarnea reopened this Jan 19, 2020
1.8.0 Release automation moved this from Done to In progress Jan 19, 2020
@ssbarnea ssbarnea added discussion WIP Work In Progress wontmerge PR Only: This pull request will not be merged (problem described in comments) labels Jan 19, 2020
@nalch
Copy link
Author

nalch commented Jan 20, 2020

No worries. Let's take the newer pull request instead to get the functionality in.

@nalch nalch closed this Jan 20, 2020
1.8.0 Release automation moved this from In progress to Done Jan 20, 2020
@nalch nalch deleted the feature/cookie-pick branch January 20, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion WIP Work In Progress wontmerge PR Only: This pull request will not be merged (problem described in comments)
Projects
No open projects
1.8.0 Release
  
Done
Development

Successfully merging this pull request may close these issues.

Migrate template changes
4 participants