Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Fail with gitolite repositories #1144

Merged
merged 3 commits into from Apr 25, 2020
Merged

Fixed: Fail with gitolite repositories #1144

merged 3 commits into from Apr 25, 2020

Conversation

javiersanp
Copy link
Contributor

@javiersanp javiersanp commented Jan 28, 2019 •
edited by insspb

Closes #1143

To fix issue #1143 I split repo_url in ':' and get the last part. I rename 'tail' to 'repo_name' which I think is more meaningfull.

@codecov-io
Copy link

codecov-io commented Jan 28, 2019 •
edited by codecov bot

Codecov Report

Merging #1144 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1144   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          18      18           
  Lines         783     806   +23     
======================================
+ Hits          783     806   +23
Impacted Files Coverage Δ
cookiecutter/vcs.py 100% <100%> (ø) ⬆️
cookiecutter/environment.py 100% <0%> (ø) ⬆️
cookiecutter/replay.py 100% <0%> (ø) ⬆️
cookiecutter/exceptions.py 100% <0%> (ø) ⬆️
cookiecutter/hooks.py 100% <0%> (ø) ⬆️
cookiecutter/extensions.py 100% <0%> (ø) ⬆️
cookiecutter/main.py 100% <0%> (ø) ⬆️
cookiecutter/prompt.py 100% <0%> (ø) ⬆️
cookiecutter/cli.py 100% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc7b98...8233837. Read the comment docs.

@hackebrot hackebrot added the enhancement This issue/PR relates to a feature request. label Aug 27, 2019
@hackebrot
Copy link
Member

Hi @javiersanp! 👋

Thank you for your contribution to cookiecutter. 🍪

@insspb insspb added the 1.8.0 label Dec 22, 2019
@ssbarnea ssbarnea closed this Jan 18, 2020
@ssbarnea ssbarnea reopened this Jan 18, 2020
@ssbarnea ssbarnea added this to the 1.8.0 milestone Mar 30, 2020
@ssbarnea ssbarnea removed the 1.8.0 label Mar 30, 2020
@insspb insspb added bug This issue/PR relates to a bug. and removed enhancement This issue/PR relates to a feature request. labels Apr 25, 2020
@insspb insspb self-assigned this Apr 25, 2020
@insspb insspb changed the title Fix fail with gitolite repositories (#1143) Fixed: Fail with gitolite repositories Apr 25, 2020
@insspb
Copy link
Member

insspb commented Apr 25, 2020

@javiersanp Thank you for contribution, excuse us for long time waiting.
I removed duplicate test and will merge it now.

@insspb insspb merged commit 3c5dd60 into cookiecutter:master Apr 25, 2020
@simobasso simobasso mentioned this pull request May 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insspb insspb insspb approved these changes

Assignees

@insspb insspb

Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Fail with gitolite repository
5 participants
@javiersanp @codecov-io @hackebrot @insspb @ssbarnea