Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Context fails when a default list value provided #1756

Closed
wants to merge 3 commits into from
Closed

Generate Context fails when a default list value provided #1756

wants to merge 3 commits into from

Conversation

simonwardjones
Copy link

@simonwardjones simonwardjones commented Aug 1, 2022

Hi, I have never contributed to cookiecutter (or any open source to be honest) but gotta say i love cookiecutter.

Currently when including a list in a default context the generate context fails. For example if you had a default context as below with a list value for the "_copy_without_render" key.

{
    "1": 2,
    "some_key": "some_val",
    "_copy_without_render": [
        "**/*.txt"
    ]
}

In particular in the cruft project there is currently an issue caused by this: cruft/cruft#166

This PR updates the apply_overwrites_to_context and updates the tests such that when overwriting, if a list is given this overwrites the whole list.

@simonwardjones simonwardjones changed the title Genrate Context fails when a default list value provided Generate Context fails when a default list value provided Aug 1, 2022
@jensens
Copy link
Contributor

jensens commented Aug 2, 2022

remark: this PR fixes issue #1757

@A160989
Copy link

A160989 commented Aug 29, 2022

any update on getting this merged in?

@adamcunnington-mlg
Copy link

+1 still blocked by this

@luisdavim
Copy link

Any chances of getting this merged any time soon?

1 similar comment
@simonwardjones
Copy link
Author

Any chances of getting this merged any time soon?

@nialloriordanroo
Copy link

I'm also blocked by this

@s-agawane
Copy link

+1 still blocked by this.

@yuvaldolev
Copy link

Hi @simonwardjones

We started working on a new community fork of the Cookiecutter project, named Cookieninja.
The fork is found at: https://github.com/cookieninja-generator/cookieninja

We have re-opened and merged your PR in the Cookieninja project at: cookieninja-generator/cookieninja#34

We're trying to bring the life back to this amazing project.
We are committed to reviewing and merging each PR in up to 2 weeks from the day it's opened (if there are no issues with it).
We'd really like you to join the fork, star it and contribute to it!

Thank you :)

@simonwardjones simonwardjones closed this by deleting the head repository Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants