Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use UTF-8 for file reading/writing #1937

Merged
merged 1 commit into from Sep 21, 2023
Merged

Use UTF-8 for file reading/writing #1937

merged 1 commit into from Sep 21, 2023

Conversation

rmartin16
Copy link
Contributor

Changes

  • Read VERSION.txt using UTF-8
  • Read and write replay JSON using UTF-8

Notes

I'm trying to add -X warn_default_encoding to beeware/briefcase's test suite....but it seems to require everything to explicitly specify encodings.

@rmartin16
Use UTF-8 for file reading/writing
cc5645a 
- Read `VERSION.txt` using UTF-8
- Read and write replay JSON using UTF-8
@rmartin16 rmartin16 marked this pull request as ready for review September 15, 2023 17:06
@rmartin16 rmartin16 mentioned this pull request Sep 15, 2023
Merged
4 tasks
@ericof ericof self-requested a review September 21, 2023 22:19
@ericof ericof added the CI/CD This issue/PR relates to the project CI/CD update or fix. label Sep 21, 2023
@ericof ericof added this to the 2.4.0 milestone Sep 21, 2023
@ericof ericof merged commit 9017b8d into cookiecutter:main Sep 21, 2023
21 checks passed
@rmartin16 rmartin16 deleted the explicit-file-encodings branch September 21, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericof ericof ericof approved these changes

Assignees
No one assigned
Labels
CI/CD This issue/PR relates to the project CI/CD update or fix.
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmartin16 @ericof