Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert readthedocs links for their .org -> .io migration for hosted projects #718

Merged
merged 1 commit into from Jun 3, 2016

Conversation

adamchainz
Copy link

As per their blog post of the 27th April ‘Securing subdomains’:

Starting today, Read the Docs will start hosting projects from subdomains on the domain readthedocs.io, instead of on readthedocs.org. This change addresses some security concerns around site cookies while hosting user generated data on the same domain as our dashboard.

Test Plan: Manually visited all the links I’ve modified.

…projects

As per [their blog post of the 27th April](https://blog.readthedocs.com/securing-subdomains/) ‘Securing subdomains’:

> Starting today, Read the Docs will start hosting projects from subdomains on the domain readthedocs.io, instead of on readthedocs.org. This change addresses some security concerns around site cookies while hosting user generated data on the same domain as our dashboard.

Test Plan: Manually visited all the links I’ve modified.
@willingc
Copy link
Contributor

willingc commented Jun 2, 2016

@adamchainz Thanks for making this change. I've manually tested your changes and reviewed the code.

Maintainers, this PR is ready to merge once appveyor finishes and is green.

@codecov-io
Copy link

Current coverage is 99.66%

Merging #718 into master will decrease coverage by 0.32%

  1. File ...ookiecutter/utils.py (not in diff) was modified. more
    • Misses +2
    • Partials 0
    • Hits -2
@@           master       #718   diff @@
========================================
  Files          13         13          
  Lines         583        583          
  Methods         0          0          
  Messages        0          0          
  Branches        0          0          
========================================
- Hits          583        581     -2   
- Misses          0          2     +2   
  Partials        0          0          

Sunburst

Powered by Codecov. Last updated by cfeece5...d2743c6

@audreyfeldroy audreyfeldroy merged commit 15e3f1d into cookiecutter:master Jun 3, 2016
@audreyfeldroy
Copy link
Member

Thanks @adamchainz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants