Fix files removed via make clean #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackebrot
added
high-priority
needs-review
Current coverage is 100% (diff: 100%)@@ master #789 diff @@
====================================
Files 15 15
Lines 601 601
Methods 0 0
Messages 0 0
Branches 0 0
====================================
Hits 601 601
Misses 0 0
Partials 0 0
|
|
Anyone? 馃榿 |
| print('pre_gen_project.py~') | ||
| """ | ||
| ) | ||
| pre_gen_hook_file = hooks_dir / 'pre_gen_project.py~' |
There was a problem hiding this comment.
These files should be in a hooks directory?
There was a problem hiding this comment.
Good catch!
In the long run we probably want to change the code to accept a path rather than using the current working directory + hooks.
|
Should be fixed now. 馃槃 |
|
馃憤 |
|
Thank you for the review @michaeljoseph! 馃檱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've added a couple of hook backup files as static files to our tests to make sure that they are not accidentally picked up as hooks in templates, see #768.
The problem is that
make cleanremoves such files and I have togit reset --hardto restore them as of now. 馃槩This PR creates the hook files in a pytest.yield_fixture and runs the test against them.