Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why was darglint removed in the python cli template? #1039

Open
picciama opened this issue Jan 20, 2023 · 2 comments
Open

Question: Why was darglint removed in the python cli template? #1039

picciama opened this issue Jan 20, 2023 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@picciama
Copy link

Question

In this commit: faaff93
darglint was removed from the pre-commit session.
What is the reason behind this?

How would I need to change this - if I overwrite my noxfile, won't the change be reverted upon next time of cookietemple sync with a new version getting pushed from TEMPLATE?

I also suggest removing .darglint from the template as it isn't used anymore if not darglint is reintegrated into the pre-commit session by default.

@picciama picciama added the question Further information is requested label Jan 20, 2023
@Zethson
Copy link
Member

Zethson commented Jan 20, 2023

If I recall correctly darglint slowed down the pre-commit a loooot for bigger packages. Hence, I removed it.

I don't think that the sync PR would suggest to remove the retrospectively added darglint, right @Imipenem ?

Ups, we somehow forgot about the .darglint file. We'll remove it.

@picciama
Copy link
Author

picciama commented Jan 20, 2023

Also delete darglint from the dev dependencies then:

@Zethson Zethson self-assigned this Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants