Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain/language specific common files folders #464

Open
Zethson opened this issue Oct 16, 2020 · 5 comments
Open

Domain/language specific common files folders #464

Zethson opened this issue Oct 16, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Zethson
Copy link
Member

Zethson commented Oct 16, 2020

I think that to scale it would be great if additionally to the common_files folder we had domain specific common_files folders such as e.g. python_common_files, which would be included if the domain matches.
Is imo required to scale.

Thoughts @Imipenem ?

@Zethson Zethson added the enhancement New feature or request label Oct 16, 2020
@Imipenem
Copy link
Collaborator

Good Idea, but I really dont know if its worth the effort. I mean, let's take python as an example: What will get included into this folder?

@Zethson
Copy link
Member Author

Zethson commented Oct 20, 2020 via email

@Imipenem
Copy link
Collaborator

I'd suggest closing this, but keep it in mind as cookietemple gets more templates. We may have to restructure some parts nevertheless so we can think about this when time has come

@Zethson Zethson added the low priority May or may not be worked on in the near future label Oct 23, 2020
@Zethson Zethson changed the title Domain specific common files folders Domain/language specific common files folders Nov 2, 2020
@Zethson
Copy link
Member Author

Zethson commented Nov 2, 2020

Well, could aid with stuff that web-python and cli-python have in common.

So not just domain common, but also language common.

@Zethson
Copy link
Member Author

Zethson commented Dec 31, 2020

Implemented in https://github.com/mlf-core/mlf-core and could be added to CT

@Zethson Zethson removed the low priority May or may not be worked on in the near future label Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants