return false instead of to make consistent result.

cookpad · Dec 5, 2022 · ef1da3c · ef1da3c
1 parent 11bc393
commit ef1da3c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/chanko/loader.rb b/lib/chanko/loader.rb
@@ -63,7 +63,7 @@ def load
         constantize
       rescue NameError
         # Chanko never raise error even if the constant fails to reference
-        nil
+        false
       end
 
       def constantize
@@ -125,7 +125,7 @@ def load_from_file_and_store_to_cache
       rescue Exception => exception
         ExceptionHandler.handle(exception)
         self.class.save_to_cache(@name, false)
-        nil
+        false
       end
 
       def load_from_cache

diff --git a/spec/chanko/loader_spec.rb b/spec/chanko/loader_spec.rb
@@ -15,16 +15,16 @@ module Chanko
 
       context "when non-existent unit name is passed" do
         it "returns nil" do
-          expect(Chanko::Loader.load(:non_existent_unit)).to eq(nil)
+          expect(Chanko::Loader.load(:non_existent_unit)).to eq(false)
         end
       end
 
       context "when loader has ever loaded specified unit" do
         it "load unit from cache", classic: true do
           expect(Chanko::Loader::ClassicLoader).to receive(:load_from_cache).twice.and_call_original
           expect(Chanko::Loader::ClassicLoader).to receive(:save_to_cache).with(anything, ExampleUnit).and_call_original
-          Chanko::Loader.load(:example_unit)
-          Chanko::Loader.load(:example_unit)
+          expect(Chanko::Loader.load(:example_unit)).to eq(ExampleUnit)
+          expect(Chanko::Loader.load(:example_unit)).to eq(ExampleUnit)
         end
       end
 
@@ -36,8 +36,8 @@ module Chanko
         it "load unit from cache", classic: true do
           expect(Chanko::Loader::ClassicLoader).to receive(:load_from_cache).twice.and_call_original
           expect(Chanko::Loader::ClassicLoader).to receive(:save_to_cache).with(anything, false).and_call_original
-          Chanko::Loader.load(:non_existent_unit)
-          Chanko::Loader.load(:non_existent_unit)
+          expect(Chanko::Loader.load(:non_existent_unit)).to eq(false)
+          expect(Chanko::Loader.load(:non_existent_unit)).to eq(false)
         end
       end
     end