Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store current unit stack in thread local storage #42

Merged
merged 2 commits into from
Jun 26, 2014

Conversation

eagletmt
Copy link
Member

Since Rails 4.0, Rails itself became thread-safe and it enables
multi-threading by default in production and test (i.e., it doesn't
insert Rack::Lock middleware).

Since Rails 4.0, Rails itself became thread-safe and it enables
multi-threading by default in production and test (i.e., it doesn't
insert Rack::Lock middleware).
@r7kamura
Copy link
Contributor

Thanks, it's a reasonable solution to use Thread.current.

@r7kamura
Copy link
Contributor

[nitpick & IMHO] We might want to use :"Chanko::Function.units" than :chanko_unit to help developer find its origin, unless there is any special reason to use it.

@eagletmt
Copy link
Member Author

Agreed. Changed it.

r7kamura added a commit that referenced this pull request Jun 26, 2014
Store current unit stack in thread local storage
@r7kamura r7kamura merged commit b341c31 into cookpad:master Jun 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants