-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support of ruby 1.9.x and 2.0.x #51
Conversation
@eagletmt How about this? |
Hi @sachin21, thank you for your contribution 👍 It looks good change for me, because supporting old and different Ruby versions can be a hard task for us. In this opportunity, we might want to re-think about supported ruby versions and gemspec's @eudoxa @eagletmt @taiki45 What do you think of this? In fact, I don't have any projects that use this library anymore, so the authority to decide this change should be owned by you, the cookpad developers. |
+1 for dropping support for Ruby <= 2.0.x. |
Make sense to me and +1. |
0f0009b
to
38bf97a
Compare
Thank you all. and thank you for your review. |
CHANGELOG.md
Outdated
@@ -1,9 +1,11 @@ | |||
## (Unreleased) | |||
* Drop support 1.9.x 2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can say "Drop support of ruby 1.9.x and 2.0.0.". Don't miss period at the end of sentence.
And I also found we mention ruby version in README, so let's change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. Thanks. I fixed it.
ffc5d5a
to
8dde164
Compare
8dde164
to
35fbea0
Compare
Thank you so much. |
Drop support 1.9.x and 2.0.x. because nokogiri requires Ruby version
>= 2.1.0
.