Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support of ruby 1.9.x and 2.0.x #51

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

sachin21
Copy link
Contributor

Drop support 1.9.x and 2.0.x. because nokogiri requires Ruby version >= 2.1.0.

@sachin21
Copy link
Contributor Author

@eagletmt How about this?

@r7kamura
Copy link
Contributor

r7kamura commented Mar 20, 2017

Hi @sachin21, thank you for your contribution 👍

It looks good change for me, because supporting old and different Ruby versions can be a hard task for us. In this opportunity, we might want to re-think about supported ruby versions and gemspec's required_ruby_version= directive.

@eudoxa @eagletmt @taiki45 What do you think of this? In fact, I don't have any projects that use this library anymore, so the authority to decide this change should be owned by you, the cookpad developers.

@eagletmt
Copy link
Member

+1 for dropping support for Ruby <= 2.0.x.
@sachin21 Could you add gem.required_ruby_version = '>= 2.1.0' ?

@taiki45
Copy link
Contributor

taiki45 commented Mar 21, 2017

Make sense to me and +1.

@sachin21
Copy link
Contributor Author

sachin21 commented Mar 21, 2017

Thank you all. and thank you for your review.
I added gem.required_ruby_version = '>= 2.1.0' and I think this is huge changes so I updated CHANGELOG.md.

CHANGELOG.md Outdated
@@ -1,9 +1,11 @@
## (Unreleased)
* Drop support 1.9.x 2.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can say "Drop support of ruby 1.9.x and 2.0.0.". Don't miss period at the end of sentence.

And I also found we mention ruby version in README, so let's change it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Thanks. I fixed it.

@sachin21 sachin21 force-pushed the drop_support_1.9_and_2.0 branch 3 times, most recently from ffc5d5a to 8dde164 Compare March 21, 2017 14:24
@sachin21 sachin21 changed the title Drop support 1.9.x and 2.0.x Drop support of ruby 1.9.x and 2.0.x Mar 21, 2017
@eagletmt eagletmt merged commit 97bed65 into cookpad:master Mar 22, 2017
@sachin21 sachin21 deleted the drop_support_1.9_and_2.0 branch March 22, 2017 16:02
@sachin21
Copy link
Contributor Author

Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants