Support late binding view #118
Merged
+138
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mysql2 adapter uses information_schema.tables to count rows. The table update when analyze table. If select table rows before analyze, table_rows return 0.
aamine
approved these changes
Apr 2, 2019
|
|
||
| def fetch_view_query_plan(query) | ||
| return nil if query.blank? | ||
| query = query.sub(/create view .*?as/, '').sub('with no schema binding', '') | ||
| super | ||
| end |
There was a problem hiding this comment.
[nits] It is not natural that super passes replaced query, you should write as super query explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for support late-binding view. The PR has 3 modification about late binding view.
pg_get_late_binding_view_colstofetch_table_names methodin redshift_adapterLATE BINDINGfetch_columnsource table tosvv_columnsViewMetaDatummodel_raw_datasetand_view_meta_dataintable_memo#showIf the table of a memo page is view regardless whether late binding or not, show the meta data like the following.