Bump up ruby version #253
Bump up ruby version #253
Conversation
| rows.map {|row| | ||
| raw_columns(table).zip(row).map {|column, value| adapter.type_cast(value, column) } | ||
| } |
There was a problem hiding this comment.
type_cast is deprecated. rails/rails#39106
These rows data are already casted.
I tried to exclude this code and then had no problem with either execution of rspec and a batch SynchronizeDataSource.
| adapter { ActiveRecord::Base.establish_connection.db_config.configuration_hash[:adapter] } | ||
| host { "localhost" } | ||
| port { 5432 } | ||
| dbname { ActiveRecord::Base.establish_connection.spec.config[:database] } | ||
| user { ActiveRecord::Base.establish_connection.spec.config[:username] } | ||
| password { ActiveRecord::Base.establish_connection.spec.config[:password] } | ||
| dbname { ActiveRecord::Base.establish_connection.db_config.configuration_hash[:database] } | ||
| user { ActiveRecord::Base.establish_connection.db_config.configuration_hash[:username] } | ||
| password { ActiveRecord::Base.establish_connection.db_config.configuration_hash[:password] } |
There was a problem hiding this comment.
ActiveRecored::Base.establish_connection returns ActiveRecord::ConnectionAdapters::ConnectionPool.
ConnectionPool.
ConnectionPool have a DatabaseConfig instead of ConnectionSpecification in Rails v6.1.
rails/rails#37253
Therefore, I replaced .spec.config[:symbol] to .db_config.confifuration_hash[:symbol].
| gem 'html-pipeline', '~> 2.5.0' | ||
| gem 'html-pipeline-rouge_filter' | ||
| gem 'html-pipeline' | ||
| gem 'rouge' |
There was a problem hiding this comment.
html-pipeline-rouge_filter has been deprecated and I will replace by rouge.
JuanitoFatas/html-pipeline-rouge_filter@322ce29
| gem 'rinku' | ||
| gem 'github-markdown' | ||
| gem 'commonmarker' |
There was a problem hiding this comment.
github-markdown has been deprecated and I will replace by commonmarker
https://rubygems.org/gems/github-markdown
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| Rails.application.config.markdown_to_html_pipeline = HTML::Pipeline.new [ | |||
| HTML::Pipeline::MarkdownFilter, | |||
| HTML::Pipeline::RougeFilter, | |||
| HTML::Pipeline::SyntaxHighlightFilter, | |||
There was a problem hiding this comment.
Configuration changes due to replacement of html-pipeline-rouge_filter gem.
| FROM ruby:2.6.2-slim-stretch | ||
| RUN apt-get update -qq && apt-get install -y build-essential libpq-dev default-libmysqlclient-dev nodejs-legacy curl git | ||
| FROM ruby:3.0.0-slim-buster | ||
| RUN apt-get update -qq && apt-get install -y build-essential libpq-dev default-libmysqlclient-dev nodejs libnode64 curl git |
There was a problem hiding this comment.
nodejs-legacy was available up to debian streatch, but not from debian buster.
This image use nodejs and libnode64 instead.
For #250 and #252
Upgrade the Ruby version to 3.0.0.
I want to keep the PR to only the Ruby version, but Rails didn't work with 3.0.0 as it was.
So, I had no choice but to update Rails as well.
Upgrading rails to v6 should affect the frontend(webpack) and DB migration(ActiveRecord), so we're going to use WIP to see how it goes.As a result of minimizing upgrading v6 effects, I made very few changes.