Enforce global name explicitly #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KOBA789
approved these changes
Mar 14, 2017
| @@ -115,7 +116,6 @@ client = GarageClient::Client.new( | |||
| adapter: :test, | |||
| headers: { "Host" => "garage.example.com" }, | |||
| endpoint: "http://localhost:3000", | |||
| name: 'my-awesome-client', | |||
taiki45
reviewed
Mar 14, 2017
| @@ -85,9 +85,6 @@ def require_necessaries(options) | |||
| if !options[:endpoint] && !default_options.endpoint | |||
| raise "Missing endpoint configuration" | |||
| end | |||
| if !options[:name] && !default_options.name | |||
There was a problem hiding this comment.
I'm not sure but why you droped checking default_options.name?
There was a problem hiding this comment.
Because options[:name] and default_options.name isn't used in Client class.
Configuration#name is used only in Configuration class itself, and the presence of name is validated there.
There was a problem hiding this comment.
Got it, then dropping these makes sense to me.
taiki45
approved these changes
Mar 14, 2017
adorechic
approved these changes
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cookpad/dev-infra @KOBA789 please have a look