Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Must specify userName when calling with non-User credentials #17

Closed
llange opened this issue Mar 29, 2016 · 4 comments
Closed

Must specify userName when calling with non-User credentials #17

llange opened this issue Mar 29, 2016 · 4 comments

Comments

@llange
Copy link
Contributor

llange commented Mar 29, 2016

On some resources I have this error on update / delete.

I'm sure that it happens for policies - maybe some others but I have no example right now.

It seems to come from https://github.com/winebarrel/miam/blob/v0.2.4/lib/miam/driver.rb#L410 (for updates) where it tries to construct the ARN for the policy.

The ARN is constructed here https://github.com/winebarrel/miam/blob/v0.2.4/lib/miam/driver.rb#L463 with the user name.
(However, the ARN for a policy has no user name in it - but the account ID)

When it tries to fetch the current user, it fails - and then cannot construct the request.

However I'm pretty sure the resulting ARN won't identify the policy as it needs the account ID.
llange added a commit to llange/miam that referenced this issue Mar 29, 2016
@llange
Tentative fix for issue cookpad#17
9467162 
This rewrites the policy_arn to use account_id instead of user_id.
I did not find a clean way to identify account_id 100% of time
without this ugly hack. (Esp. when using IAM identities +
switch roles).
I'd be interested in a clean way to do that.
winebarrel pushed a commit that referenced this issue Mar 31, 2016
Merge pull request #18 from llange/fix_issue17_policy_arn
016c924 
Tentative fix for issue #17
@yayugu
Copy link

yayugu commented Aug 30, 2016

STS GetCallerIdentity is better API to get account ID.
http://docs.aws.amazon.com/STS/latest/APIReference/API_GetCallerIdentity.html

gree/subiam@9dc9087

llange pushed a commit to llange/miam that referenced this issue Jan 17, 2017
Second tentative fix for issue cookpad#17
443550c 
Applying @yayugu 's patch : gree/subiam@9dc9087
Works as expected.
@llange
Copy link
Contributor Author

llange commented Jan 17, 2017 •
edited
Loading

@yayugu 's patch works fine.

Please merge it - you can merge it from my branch llange/miam@443550c if easier.

@winebarrel winebarrel mentioned this issue Jan 17, 2017
Merged
winebarrel pushed a commit that referenced this issue Jan 17, 2017
Merge pull request #24 from winebarrel/fix_for_non_user_credentials
58152e8 
Second tentative fix for issue #17
@winebarrel
Copy link
Collaborator

@llange I am sorry for the late reply. 🙇
I merged your commit and released v0.2.4.beta9.

@yayugu Thanks for your comment.

@llange
Copy link
Contributor Author

llange commented Jan 10, 2019

I'm so late, sorry, but after near one year I'm closing this issue. Thanks !

@llange llange closed this as completed Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@winebarrel @yayugu @llange