Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sorted keys when encoding using the JSON strategy #20

Merged
merged 2 commits into from Jan 26, 2024

Conversation

liamnichols
Copy link
Member

This change is minor for the end-user where the order of JSON object keys isn't really important, but this causes a failure when running Unit Tests in Xcode 15 due to changes in the iOS 17 SDK:

Screenshot 2024-01-26 at 12 37 35

Therefore we enforce sorted keys moving forward

@liamnichols liamnichols self-assigned this Jan 26, 2024
@liamnichols liamnichols merged commit 2fcd945 into main Jan 26, 2024
2 checks passed
@liamnichols liamnichols deleted the ln/json-sorted-keys branch January 26, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant