Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default behaviour of endpoint_public_access is not a secure default #253

Closed
bermannoah opened this issue Oct 19, 2021 · 5 comments · Fixed by #240
Closed

Default behaviour of endpoint_public_access is not a secure default #253

bermannoah opened this issue Oct 19, 2021 · 5 comments · Fixed by #240

Comments

@bermannoah
Copy link

bermannoah commented Oct 19, 2021

https://github.com/cookpad/terraform-aws-eks/blob/main/modules/cluster/variables.tf#L6-L10

variable "endpoint_public_access" {
  type        = bool
  description = "Indicates whether or not the Amazon EKS public API server endpoint is enabled."
  default     = true
}

This behaviour is insecure, see https://tfsec.dev/docs/aws/eks/no-public-cluster-access/#aws/eks

@errm
Copy link
Member

errm commented Oct 19, 2021

This will be fixed by #240

@bermannoah
Copy link
Author

Ah! Anything I can do to help get that merged? 😃

@errm
Copy link
Member

errm commented Oct 19, 2021

It's a breaking change, so we were keeping it for the 1.20 release - check with @ettiee about progress on that?

@ettiee
Copy link
Contributor

ettiee commented Oct 19, 2021

It's a breaking change, so we were keeping it for the 1.20 release - check with @ettiee about progress on that?

We're working on features for the 1.20 release now so we can merge it :)

@bermannoah
Copy link
Author

Shall we? @errm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants