Add tfsec, and fix reported issues #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfsec uses static analysis of your terraform templates to spot potential security issues. https://tfsec.dev/
Fixes tfsec AWS066 see: https://tfsec.dev/docs/aws/eks/encrypt-secrets#aws/eks
Long life KMS keys increase the attack surface when compromised fixes: tfsec AWS019 https://tfsec.dev/docs/aws/kms/auto-rotate-keys#aws/kms
Log data may be leaked if the logs are compromised. No auditing of who have viewed the logs. fixes: tfsec AWS089 https://tfsec.dev/docs/aws/cloudwatch/log-group-customer-key#aws/cloudwatch
Disables public access to EKS Clusters by default. Fixes tfsec: AWS069 To have previous default behaviour you now need to set: ``` endpoint_public_access = true endpoint_public_access_cidrs = ["0.0.0.0/0"] ``` https://tfsec.dev/docs/aws/eks/no-public-cluster-access#aws/eks
These IAM polices need wildcard rules for the correct functioning of our name tagging script and the cluster autoscaler. I think it is OK to have these wildcards as I can't think of a more restrictive way to specify the required permissions.
|
👏 Really nice improvement! ❓ I've noticed that |
|
📝 This is probably something we should add to release notes:
|
takanabe
pushed a commit
that referenced
this pull request
Nov 5, 2021
ettiee
added a commit
that referenced
this pull request
Nov 16, 2021
Since #240 we require secret encrytion on all clusters. Users hit this bug after enabling secret encryption hashicorp/terraform-provider-aws#19986 unless using aws provider >=3.49.0
ettiee
added a commit
that referenced
this pull request
Nov 16, 2021
Since #240 we require secret encrytion on all clusters. Users hit this bug after enabling secret encryption hashicorp/terraform-provider-aws#19986 unless using aws provider >=3.49.0
ettiee
added a commit
that referenced
this pull request
Nov 16, 2021
Since #240 we require secret encrytion on all clusters. Users hit this bug after enabling secret encryption hashicorp/terraform-provider-aws#19986 unless using aws provider >=3.49.0
ettiee
added a commit
that referenced
this pull request
Nov 16, 2021
Since #240 we require secret encrytion on all clusters. Users hit this bug after enabling secret encryption hashicorp/terraform-provider-aws#19986 unless using aws provider >=3.49.0
ettiee
added a commit
that referenced
this pull request
Nov 17, 2021
Since #240 we require secret encrytion on all clusters. Users hit this bug after enabling secret encryption hashicorp/terraform-provider-aws#19986 unless using aws provider >=3.49.0
ettiee
added a commit
that referenced
this pull request
Nov 17, 2021
Since #240 we require secret encrytion on all clusters. Users hit this bug after enabling secret encryption hashicorp/terraform-provider-aws#19986 unless using aws provider >=3.49.0
ettiee
added a commit
that referenced
this pull request
Nov 17, 2021
Since #240 we require secret encrytion on all clusters. Users hit this bug after enabling secret encryption hashicorp/terraform-provider-aws#19986 unless using aws provider >=3.49.0
ettiee
added a commit
that referenced
this pull request
Nov 19, 2021
Since #240 we require secret encrytion on all clusters. Users hit this bug after enabling secret encryption hashicorp/terraform-provider-aws#19986 unless using aws provider >=3.49.0
ettiee
added a commit
that referenced
this pull request
Nov 19, 2021
Since #240 we require secret encrytion on all clusters. Users hit this bug after enabling secret encryption hashicorp/terraform-provider-aws#19986 unless using aws provider >=3.49.0
ettiee
added a commit
that referenced
this pull request
Nov 19, 2021
Since #240 we require secret encrytion on all clusters. Users hit this bug after enabling secret encryption hashicorp/terraform-provider-aws#19986 unless using aws provider >=3.49.0
ettiee
added a commit
that referenced
this pull request
Dec 6, 2021
ettiee
added a commit
that referenced
this pull request
Dec 6, 2021
…anges Add #240 as a breaking change in UPGRADING.md for 1.20 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tfsec uses static analysis of your terraform templates to spot potential security issues.
https://tfsec.dev/
Fixes #253