rename oidc outputs

[ettiee]

Replaces #169

[github-actions]

terraform fmt Failed

./modules/asg_node_group/main.tf

     }
 
     instances_distribution {
-      on_demand_base_capacity                  = 0
-      on_demand_percentage_above_base_capacity = (var.instance_lifecycle == "on_demand" ? 100 : 0)
-      spot_allocation_strategy                 = var.spot_allocation_strategy
-      spot_instance_pools                      = max(floor(length(local.instance_types) / 2), 2)
+      on_demand_base_capacity = 0
+      on_demand_percentage_above_base_capacity = (var.instance_lifecycle == "on_demand" ? 100 : 0
+      ) spot_allocation_strategy = var.spot_allocation_strategy
+      spot_instance_pools        = max(floor(length(local.instance_types) / 2), 2)
     }
   }
 

./modules/cluster/addons.tf

 }
 
 locals {
-  dns_cluster_ip = length(var.dns_cluster_ip) > 0 ? var.dns_cluster_ip : (split(".", data.aws_vpc.network.cidr_block)[0] == "10" ? "172.20.0.10" : "10.100.0.10")
-}
+  dns_cluster_ip = length(var.dns_cluster_ip) > 0 ? var.dns_cluster_ip : (split(".", data.aws_vpc.network.cidr_block)[0] == "10" ? "172.20.0.10" : "10.100.0.10"
+) }
 
 module "coredns" {
   source = "./kubectl"

Workflow: .github/workflows/ci.yml, Action: hashicorpterraform-github-actions1, Working Directory: ., Workspace: default

[errm]

I should have fixed the linting issue on master ... if you rebase everything should be green!

[ettiee]

@dan-slinky-ckpd @aidy can you take a 👀 on this check you're happy for the stable 1.18 cut - it's a breaking configuration change (very minor) for teams upgrading

[aidy]

LGTM

[dan-slinky-ckpd]

LGTM. Lets get an update to https://github.com/cookpad/terraform-aws-eks/blob/master/UPGRADING.md asap though, so we don't forget.