Initial 1.19 support upgrade

[ettiee]

Ref #197

• Upgrade cluster / node group versions
• Upgrade core addons to recommended versions (coredns / kube-proxy)
• Upgrade other addons to latest compatible versions

For discussion

EKS no longer adds kubernetes.io/cluster/ tags to subnets

We are on the latest load-balancer-controller so we do not need to support these tags for compatibility. However, these tags are required for auto discovery on load balancer creation. I think this is the way we should encourage teams to operate (and is how they do now). The implication for PR changes:

• Add tags to subnets in vpc module
• remove lifecycle change ignore on tags in vpc module
• Recommend users to codify these tags if they are not using the vpc module

[ettiee]

@aidy @dan-slinky-ckpd @errm let me know your opinion on

EKS no longer adds kubernetes.io/cluster/ tags to subnets

If you agree we should default to keeping these tags on subnets I'll fix the tests and make the tags optional in the VPC module.

[errm]

However, these tags are required for auto discovery on load balancer creation.

Could you explain some more about this? Is there a link to documentation about the situations where it would be needed?

[ettiee]

Could you explain some more about this? Is there a link to documentation about the situations where it would be needed?

Thanks @errm 🙏 it's for the auto discovery for aws load balancer controller https://kubernetes-sigs.github.io/aws-load-balancer-controller/latest/deploy/subnet_discovery/
In practice - without those subnet tags users will need to specify the tag alb.ingress.kubernetes.io/subnets on their ingress definitions.

[aidy]

EKS no longer adds kubernetes.io/cluster/ tags to subnets

I think that makes sense to me.

[ettiee]

From yesterday's discussions with @aidy - plan to introduce cert-manager to avoid generating self-signed certs for the aws-load-balancer will be done in #205
I've implemented the more opinionated VPC / subnet tags in the VPC module example - and upgrade notes for users to add them if they terraform their own VPC.
Remaining review can focus on the 1.19 upgrade + updates to critical addons

[dan-slinky-ckpd]

LGTM. Gimme an RC :)