Do not always call setPlaybackRate on play

cookpete · Aug 18, 2019 · 2b59631 · 2b59631
1 parent f91c737
commit 2b59631
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/Player.js b/src/Player.js
@@ -171,7 +171,7 @@ export default class Player extends Component {
     this.isLoading = false
     const { onStart, onPlay, playbackRate } = this.props
     if (this.startOnPlay) {
-      if (this.player.setPlaybackRate) {
+      if (this.player.setPlaybackRate && playbackRate !== 1) {
         this.player.setPlaybackRate(playbackRate)
       }
       onStart()

diff --git a/test/Player.js b/test/Player.js
@@ -233,14 +233,11 @@ test('onPlay()', t => {
 
 test('onStart()', t => {
   const onStart = sinon.fake()
-  const setPlaybackRate = sinon.fake()
   const instance = shallow(<Player onStart={onStart} />).instance()
-  instance.ref({ setPlaybackRate })
   instance.handleDurationCheck = sinon.fake()
   instance.startOnPlay = true
   instance.handlePlay()
   t.true(onStart.calledOnce)
-  t.true(setPlaybackRate.calledOnceWith(1))
   t.false(instance.startOnPlay)
 })