Use shouldComponentUpdate to prevent unnecessary rendering

YouTube and Vimeo actually don't ever need re-rendering SoundCloud only needs to render once it has artwork to display
cookpete · Aug 27, 2015 · b7ca5a6 · b7ca5a6
1 parent b86c76a
commit b7ca5a6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/src/players/SoundCloud.js b/src/players/SoundCloud.js
@@ -18,6 +18,9 @@ export default class SoundCloud extends Base {
   state = {
     image: null
   }
+  shouldComponentUpdate (nextProps, nextState) {
+    return this.state.image !== nextState.image
+  }
   getSDK () {
     if (window[SDK_GLOBAL]) {
       return Promise.resolve(window[SDK_GLOBAL])

diff --git a/src/players/Vimeo.js b/src/players/Vimeo.js
@@ -17,6 +17,9 @@ export default class Vimeo extends Base {
     this.iframe = this.refs.iframe.getDOMNode()
     super.componentDidMount()
   }
+  shouldComponentUpdate () {
+    return false
+  }
   play (url) {
     if (url) {
       let id = url.match(MATCH_URL)[3]

diff --git a/src/players/YouTube.js b/src/players/YouTube.js
@@ -14,6 +14,9 @@ export default class YouTube extends Base {
   static canPlay (url) {
     return MATCH_URL.test(url)
   }
+  shouldComponentUpdate () {
+    return false
+  }
   getSDK () {
     if (window[SDK_GLOBAL]) {
       return Promise.resolve(window[SDK_GLOBAL])