Skip to content

Commit

Permalink
Remove unnecessary stop logic from soundcloud
Browse files Browse the repository at this point in the history
The widget is an iframe that gets unmounted, so I can't see why pausing and seeking beforehand is necessary
  • Loading branch information
cookpete committed Sep 15, 2017
1 parent 84ad345 commit f478f1a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/players/Facebook.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export default class Facebook extends Base {
this.callPlayer('pause')
}
stop () {
// No need to stop
// Nothing to do
}
seekTo (amount) {
const seconds = super.seekTo(amount)
Expand Down
3 changes: 1 addition & 2 deletions src/players/SoundCloud.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ export default class SoundCloud extends Base {
}
}
stop () {
this.pause()
this.callPlayer('seekTo', 0)
// Nothing to do
}
seekTo (amount) {
const seconds = super.seekTo(amount)
Expand Down

0 comments on commit f478f1a

Please sign in to comment.