Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with playbackRate when switching videos #1052

Closed
toschlog opened this issue Oct 15, 2020 · 1 comment
Closed

Error with playbackRate when switching videos #1052

toschlog opened this issue Oct 15, 2020 · 1 comment

Comments

@toschlog
Copy link

Be sure to search for your issue before opening a new one.

Current Behavior

When switching from a Vimeo video to a YouTube video on Mac, I get this error:

image

Steps to Reproduce

I have a repro case, but it looks to me like you just need to return from componentDidUpdate before checking the properties if this.player isn't defined. If it's more complicated than that and you need more information, I'm happy to help.

Environment

Chrome, Mac
@cookpete
Copy link
Owner

I'm curious how you got this to happen?

Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
@Webmaster1116
Prevent errors when updating without a player
397099d 
Fixes cookpete/react-player#1052
Fixes cookpete/react-player#1074
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
@webmiraclepro
Prevent errors when updating without a player
cc907fb 
Fixes cookpete/react-player#1052
Fixes cookpete/react-player#1074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cookpete @toschlog