Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on Dailymotion link regex #1430

Closed
Maxou44 opened this issue Apr 3, 2022 · 4 comments
Closed

Issue on Dailymotion link regex #1430

Maxou44 opened this issue Apr 3, 2022 · 4 comments

Comments

@Maxou44
Copy link
Contributor

Maxou44 commented Apr 3, 2022

Current Behavior

This valid link is not recognized as a Dailymotion link and the React Player fallback on the video element:

http://www.dailymotion.com/video/xdni1e_l-histoire-etrange-1_creation#.UXRVsbXwn90

Expected Behavior

Ignore dot or # character in the Dailymotion regex, to display it correctly.

egon-isnoise pushed a commit to egon-isnoise/react-player-fixing that referenced this issue Oct 8, 2022
egon-isnoise pushed a commit to egon-isnoise/react-player-fixing that referenced this issue Oct 8, 2022
egon-isnoise pushed a commit to egon-isnoise/react-player-fixing that referenced this issue Oct 8, 2022
@RobertoLlopis
Copy link

RobertoLlopis commented Oct 8, 2022

Hello.

We are a team from Alicante (Spain) enjoying hacktober fest and chose your repo to try to give our little contribution.

Hope everything is ok with that.

PR: #1516

@Maxou44
Copy link
Contributor Author

Maxou44 commented Dec 31, 2022

Same issue with a "?" character on this URL: "http://www.dailymotion.com/video/x4sznp_henri-edmond-le-nouveau-voisin-uk-s_creation?search_algo=2#.UZ-XHYJ1ZGE". For Dailymotion, I think we should remove anything after the "?" or "#".

@Maxou44
Copy link
Contributor Author

Maxou44 commented Feb 3, 2023

Thanks for the fix!

@cookpete
Copy link
Owner

cookpete commented Feb 9, 2023

Published in v2.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants