-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue on Dailymotion link regex #1430
Comments
Hello. We are a team from Alicante (Spain) enjoying hacktober fest and chose your repo to try to give our little contribution. Hope everything is ok with that. PR: #1516 |
Same issue with a "?" character on this URL: "http://www.dailymotion.com/video/x4sznp_henri-edmond-le-nouveau-voisin-uk-s_creation?search_algo=2#.UZ-XHYJ1ZGE". For Dailymotion, I think we should remove anything after the "?" or "#". |
Thanks for the fix! |
Published in |
Current Behavior
This valid link is not recognized as a Dailymotion link and the React Player fallback on the video element:
http://www.dailymotion.com/video/xdni1e_l-histoire-etrange-1_creation#.UXRVsbXwn90
Expected Behavior
Ignore dot or # character in the Dailymotion regex, to display it correctly.
The text was updated successfully, but these errors were encountered: