Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onProgress non-reporting if playing prop is not set. #127

Closed
wants to merge 2 commits into from

Conversation

tarhan
Copy link
Contributor

@tarhan tarhan commented Nov 20, 2016

Simple fix for onProgress bug mentioned here: #126

Demo app used Date for convert total seconds to hours, minutes and seconds.
It set Date in UTC format but read in local time zone.
As result localtime zone hours count added to output.
@cookpete
Copy link
Owner

cookpete commented Dec 2, 2016

Why change the onProgress default to null and add a guard against it? Seems like an attempt to solve a problem that doesn't exist, and isn't related to the commit. Happy to merge this after you remove those changes.

cookpete added a commit that referenced this pull request Dec 12, 2016
Fix onProgress non-reporting if playing prop is not set.
@cookpete
Copy link
Owner

Fixed up and merged manually. Thanks!

@cookpete cookpete closed this Dec 12, 2016
@cookpete cookpete mentioned this pull request Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants