Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flvjs error handling, pass it to props onError method. #1426

Merged

Conversation

mjankovskis
Copy link
Contributor

When flvjs instance emits error it is not passed to the react player instance.

Expected behavior

Error should be passed to onError handler

Steps to Reproduce

git clone https://github.com/CookPete/react-player.git
cd react-player
npm install # or yarn
npm start
open http://localhost:3000

In Custom URL write file.flv

> events.js:62 Uncaught (in promise) Error: Uncaught, unspecified "error" event. (NetworkError)
    at i.emit (events.js:62:1)
    at i.<anonymous> (flv-player.js:236:27)
    at i.emit (events.js:84:1)
    at transmuxer.js:189:27

After fix

> onError NetworkError

@cookpete cookpete merged commit bc8fe6b into cookpete:master May 7, 2022
@cookpete
Copy link
Owner

cookpete commented May 7, 2022

Published in 2.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants