Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes react-18 youtube error #1439 #1450

Closed
wants to merge 1 commit into from
Closed

fixes react-18 youtube error #1439 #1450

wants to merge 1 commit into from

Conversation

manishsharma004
Copy link

@manishsharma004 manishsharma004 commented May 5, 2022 •
edited
Loading

fixes #1439

@manishsharma004 manishsharma004 mentioned this pull request May 5, 2022
Closed
@lehnerpat
Copy link

just tested this by patching my react-player (v2.10.0) contents in node_modules, and can confirm that it resolves the problems from #1439.

Would appreciate it if this could be merged and released soon :)

@cookpete cookpete closed this in d053d4a May 7, 2022
@cookpete
Copy link
Owner

cookpete commented May 7, 2022

I went for a slightly more elegant fix :) Thanks for the PR though! Fixed in 2.10.1

@lehnerpat lehnerpat mentioned this pull request May 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings with React 18
3 participants
@manishsharma004 @lehnerpat @cookpete