Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "sideEffects": false to package.json #1524

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Add "sideEffects": false to package.json #1524

merged 1 commit into from
Feb 3, 2023

Conversation

emanuelpalm
Copy link
Contributor

I'm using this package as a dependency, and I want Webpack to be able to optimize it out automatically if it ends up being the case that I do not use it (or only use parts of it).

Skimming through the source code, I don't see any of the files running any code as the files are loaded, which should mean that the project qualifies as being side-effect free and can be optimized by Webpack.

I'm using this package as a dependency, and I want Webpack to be able to [optimize it out automatically](https://webpack.js.org/configuration/optimization/#optimizationsideeffects) if it ends up being the case that I do not use it (or only use parts of it).

Skimming through the source code, I don't see any of the files running any code as the files are loaded, which should mean that the project qualifies as being side-effect free and can be optimized by Webpack.
@cookpete cookpete merged commit 1677c57 into cookpete:master Feb 3, 2023
@cookpete
Copy link
Owner

cookpete commented Feb 9, 2023

Published in v2.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants