Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deno compatibility #1632

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Deno compatibility #1632

merged 1 commit into from
Feb 21, 2024

Conversation

arnemolland
Copy link
Contributor

@arnemolland arnemolland commented May 7, 2023 •
edited

Draft/suggestion for #1631. The typeof document check is needed for Deno environments, as window is part of the runtime API.

@arnemolland arnemolland changed the title Add option to disable Suspense Deno compatibility Oct 27, 2023
@arnemolland arnemolland mentioned this pull request Oct 27, 2023
Closed
@arnemolland arnemolland marked this pull request as ready for review October 27, 2023 07:15
luwes
luwes approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you for the contribution

@luwes luwes merged commit 132a9d3 into cookpete:master Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luwes luwes luwes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arnemolland @luwes