Fixed broken TypeScript type definitions #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookpete
requested changes
Sep 5, 2017
index.d.ts
Outdated
| @@ -1,7 +1,19 @@ | |||
| import * as React from 'react'; | |||
|
|
|||
| export interface SourceSpec { | |||
There was a problem hiding this comment.
Is there any point export ing SourceSpec and TrackSpec? They are only used in this file.
There was a problem hiding this comment.
They are only used in this file.
Sure?
If you want to prepare an object of type SourceSpec somewhere in your source you'll be happy to be able to import that type.
index.d.ts
Outdated
| type: string; | ||
| } | ||
|
|
||
| export interface TrackSpec { |
There was a problem hiding this comment.
I think the names SourceProps and TrackProps make more sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #229