Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react-transform development setup #25

Merged
merged 3 commits into from
Jan 9, 2016
Merged

Conversation

cookpete
Copy link
Owner

@cookpete cookpete commented Jan 5, 2016

Creating this to soften the blow for anyone else using this (namely @Fauntleroy 馃帀).

It basically:

  • Rebases the project on my fork of react-transform-boilerplate, which is inherently better than the current way
  • Adds some starter karma tests to build on (although annoyingly they don't work in travis (see 2f41434)
  • Paves the way for a better demo app, including demo build script and scss support. Maybe even a ReactPlayerWithControls component?
  • Sets NODE_ENV=production when compiling, so we don't include any babel development code in the build

Notice that this PR doesn't touch src. No changes to any source files, just the way they are handled and compiled.

@cookpete
Copy link
Owner Author

cookpete commented Jan 5, 2016

Updated. Managed to fix karma tests in Travis by configuring Travis to use Chrome. Firefox wasn't playing ball.

@cookpete cookpete force-pushed the transform-boilerplate branch 4 times, most recently from 4a5c449 to ede3948 Compare January 7, 2016 19:55
cookpete added a commit that referenced this pull request Jan 9, 2016
Use react-transform development setup
@cookpete cookpete merged commit 4800724 into master Jan 9, 2016
@cookpete cookpete deleted the transform-boilerplate branch January 9, 2016 16:53
@mgw-sbex mgw-sbex mentioned this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant