Add support for non-es5 compatible browsers #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Piatek <do.piatek@gmail.com>
|
Hi @dpiatek, what is the reserved word that causes problems? I wonder if it will be cleaner to refactor the code to prevent the errors. |
|
The keyword in question is |
|
Ah ok so it's a problem with babel's output itself, not the codebase. I've just read more about it here. Thanks for the PR! |
|
thanks @cookpete - and for open sourcing this as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @cookpete ! This adds two babel plugins that will make it possible to run non-dist code in non-es5 compatible environments. As far as I can tell this has no further effect on the codebase (tests passed fine locally).
http://babeljs.io/docs/plugins/transform-es3-member-expression-literals/
http://babeljs.io/docs/plugins/transform-es3-property-literals/