Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy using Travis when pushing a Git tag #24

Closed
bittner opened this issue Apr 23, 2019 · 3 comments
Closed

Deploy using Travis when pushing a Git tag #24

bittner opened this issue Apr 23, 2019 · 3 comments

Comments

@bittner
Copy link
Collaborator

bittner commented Apr 23, 2019

Instead of deploying from your local machine we should let Travis do the job of releasing new versions of this package. This has a few significant advantages:

  1. What happens at releases is better documented with an audit trail (CI jobs log).
  2. Releasing then enforces tagging on commits that are related to a release.
  3. No software needs to be installed on your local machine for pushing a new release.

See these projects for working examples: (deploy job in .travis.yml)

@cool-RR
Copy link
Owner

cool-RR commented Apr 23, 2019 via email

@bittner
Copy link
Collaborator Author

bittner commented Apr 24, 2019

You can now update the Travis configuration with your encrypted PyPI password. You'll need the travis CLI for this (I usually run a travis-cli Docker image, because the CLI is painful to install on my Ubuntu box). Afterwards pushing a Git tag will trigger a deployment on PyPI via Travis.

I'd also suggest to move the version number into the pysnooper/__init__.py file to avoid having to touch setup.py for each version bump. See examples:

@cool-RR
Copy link
Owner

cool-RR commented Apr 25, 2019

I'm going to put this on hold. When the Travis builds broke yesterday when I made the version change, I was completely helpless to fix them. I couldn't figure out how the .travis.yml and tox.ini files were dictating Travis's behavior. I had to try lots of different things and everything failed, so I bundled all the dependencies. I don't want to depend on Travis for releases because if it breaks in the future I might not have a known flow for making a release. Sorry.

We might revisit this later.

@cool-RR cool-RR closed this as completed Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants