Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary usage of BG2 API #5

Closed
GotoLink opened this issue Sep 11, 2014 · 1 comment
Closed

Unnecessary usage of BG2 API #5

GotoLink opened this issue Sep 11, 2014 · 1 comment

Comments

@GotoLink
Copy link

I would like to point out that ItemHeroBow implements IBattlegearWeapon, which isn't necessary to allow handling of such item in Mine&Blade-Battlegear2 slots. (It is even counterproductive here, as it always returns false in #allowOffhand(ItemStack, ItemStack) making it totally unwieldable)
Extending ItemBow is enough to allow the handling in the right hand. You could allow the wielding in left hand, but it wouldn't be "used" as a bow even in the latest version of Battlegear.
So unless you have specific requirements for this item usage, i'd recommend removing that interface.

@coolAlias
Copy link
Owner

Thanks Goto, you were absolutely right. IAllowItem on its own was plenty, and even that probably unnecessary since I extend ItemBow. Anyway, it works great now xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants