Figure out what to do with previously-commented-out Lua

[cooljeanius]

Normally, in languages with a preprocessor (C, WML, autoconf/m4), I like to change commented-out code into ifdef-ed out code instead, so that it's easier to re-enable if necessary. Lua doesn't have a preprocessor, though, AFAIK. So, instead I'll want to find something else to do with the commented-out Lua code: just remove it? Have it guarded by a language-level conditional? If so, what should the guarding conditional generally be? wesnoth.game_config.debug_mode?

[cooljeanius]

If so, what should the guarding conditional generally be? wesnoth.game_config.debug_mode?

(Note that wesnoth.game_config.debug_mode makes sense for stuff that was commented out due to being debug messages that don't need to be seen in production, but it doesn't make sense for stuff that was commented out due to being broken or buggy... I guess the main issue at hand for this bug, then, is telling the difference between the two...)

[cooljeanius]

working on this

[cooljeanius]

I'll probably want to remove some of those dbms() calls, but for now let's just wait for a response to Elvish-Hunter/Wesnoth_Lua_Pack#6

[cooljeanius]

ok I think the current handling of them is probably fine; there are still dbms() usages there, but they're extremely highly conditionalized, so I doubt an average player will be running into them.