Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open PR for my UtBS changes upstream #9

Closed
cooljeanius opened this issue Jul 20, 2021 · 4 comments · May be fixed by wesnoth/wesnoth#8421
Closed

open PR for my UtBS changes upstream #9

cooljeanius opened this issue Jul 20, 2021 · 4 comments · May be fixed by wesnoth/wesnoth#8421
Assignees
@cooljeanius
Projects
Wesnoth UMC

Comments

@cooljeanius
Copy link
Owner

Given that Yumi gave UtBS a major rework for 1.15/1.16, my changes might not apply cleanly... also there were some further changes I wanted to make, and testing them might require a new playthru...
@cooljeanius cooljeanius added this to To Do in Wesnoth UMC via automation Jul 20, 2021
@cooljeanius
Copy link
Owner Author

diffs are here: https://github.com/cooljeanius/wesnoth_mods/tree/master/campaigns/Under_the_Burning_Suns/diffs

@cooljeanius cooljeanius self-assigned this Sep 15, 2021
@cooljeanius
Copy link
Owner Author

I dunno if I'm actually going to get around to this before it's too late...

@cooljeanius
Copy link
Owner Author

I dunno if I'm actually going to get around to this before it's too late...

update: wesnoth/wesnoth#8281 will probably break any diffs I had here; I'll close this once it's merged...

cooljeanius added a commit to cooljeanius/wesnoth that referenced this issue Feb 17, 2024
@cooljeanius
initial attempt at applying my patches
0b0f4d9 
see cooljeanius/wesnoth_mods#9
see https://github.com/cooljeanius/wesnoth_mods/tree/master/campaigns/Under_the_Burning_Suns/diffs
cooljeanius added a commit to cooljeanius/wesnoth that referenced this issue Feb 17, 2024
@cooljeanius
try wiggling in the remaining rejects files
5b759c2 
see cooljeanius/wesnoth_mods#9
see https://github.com/cooljeanius/wesnoth_mods/tree/master/campaigns/Under_the_Burning_Suns/diffs
@cooljeanius cooljeanius mentioned this issue Feb 17, 2024
Draft
@cooljeanius
Copy link
Owner Author

OK, I opened wesnoth/wesnoth#8421

Wesnoth UMC automation moved this from To Do to Done Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cooljeanius cooljeanius

Labels
None yet
Projects
Wesnoth UMC
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tweak UtBS difficulty cooljeanius/wesnoth
1 participant
@cooljeanius