Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix one-shot commands for a specific container being executed using host environment variables #2173

Conversation

maurobender
Copy link
Contributor

@maurobender maurobender commented May 8, 2024

With this change the one-shot commands run from the UI use the environment variables from the container instead of the host.

Closes #2172.

Example:

Container env vars:

Captura de pantalla 2024-05-08 a la(s) 19 28 29

One-shot command using env vars from the container works as expected now:

Captura de pantalla 2024-05-08 a la(s) 19 29 09

String quoted is executed correctly:

Captura de pantalla 2024-05-08 a la(s) 19 29 50

@andrasbacsai
Copy link
Member

Thank you for the PR! I will test it if everything works as expected!

@andrasbacsai andrasbacsai changed the base branch from main to next May 10, 2024 07:45
@andrasbacsai andrasbacsai merged commit 00e7167 into coollabsio:next May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Running one-shot command inside a container doesn't handle env variables correctly
2 participants