Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to kill Dropbear / Dropbear settings are overwritten #32

Closed
ninoz opened this issue Jan 18, 2018 · 5 comments
Closed

Unable to kill Dropbear / Dropbear settings are overwritten #32

ninoz opened this issue Jan 18, 2018 · 5 comments

Comments

@ninoz
Copy link

ninoz commented Jan 18, 2018

With the new addition of the launchctl and dropbear being ran under launchd, the daemon is restarting the dropbear process when its being killed.

Changes to the dropbear.plist to not have to kept ssh alive and to only run on 127.0.0.1 are lost as the file is overwritten each time electra is ran.

Can electra run file_exist on the plist before overwriting the file.

cp("/bootstrap/Library/LaunchDaemons/dropbear.plist", progname("dropbear.plist"));

Thanks for all your work :)

Added a pull request with some changes, runs okay on my device and the dropbear changes remain after a reboot and rejailbreak

#33

@nullpixel
Copy link
Contributor

nullpixel commented Jan 18, 2018

I don’t think we can merge #33 because of implications it could have for normal users, but I’ll let coolstar decide

@stek29
Copy link
Contributor

stek29 commented Jan 18, 2018

@nullpixel Agreed. I'd rather just remove option to start after kill.

@ninoz
Copy link
Author

ninoz commented Jan 18, 2018

I agreee setting to 127.0.0.1 maybe be somewhat difficult for the normal user. #33 only sets a check on if the plist has been created it doesn’t change the plist itself.

The issue I was raising was more that the dropbear modifications are lost on each running of Electra.

If it’s already there it doesn’t make sense to overwrite it and cause the user to lose their dropbear modifications.

@ninoz ninoz changed the title Unable to kill Dropbear Unable to kill Dropbear / Dropbear settings are overwritten Jan 18, 2018
@nullpixel
Copy link
Contributor

the overwriting is meant to be there: i purposely added it. it allows us to update the plist

@ninoz
Copy link
Author

ninoz commented Jan 19, 2018

That's fair enough, thanks again for all the effort you guys are putting in :)

@ninoz ninoz closed this as completed Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants