Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transcode, sign and encrypt files for transmission #50

Merged
merged 23 commits into from
Dec 15, 2021
Merged

transcode, sign and encrypt files for transmission #50

merged 23 commits into from
Dec 15, 2021

Conversation

michaelkamphausen
Copy link
Member

Closes #23, #20, #21 and #12

@michaelkamphausen
fixed tests according to latest I8 encoding related changes to data s…
9a0c4ff 
…tructure
@michaelkamphausen
encode to and decode from I8 as Uint8Array
eb3db60
@michaelkamphausen
added control characters to I7 (and I8) code tables to be able to enc…
c92e81c 
…ode new lines and tabs
@michaelkamphausen
Auftragsdatei is encoded with ISO 8-bit instead of ISO-8859-1 now
b637bcc
@michaelkamphausen
Merge commit 'ea7223f97f3dbd5561cc6061c029dbb469007576' into feat/tra…
4e02d5a 
…nscode-sign-encrypt-files

# Conflicts:
#	tests/kostentraeger/index.spec.ts
@michaelkamphausen
Merge commit 'ec168894a09e33692658543bb23524e8d79a5ab7' into feat/tra…
45cdef9 
…nscode-sign-encrypt-files

# Conflicts:
#	tests/kostentraeger/index.spec.ts
@michaelkamphausen
Merge commit 'f1d4db3ea4369bcf1523d49d0b182667b445e51f' into feat/tra…
5d4a0d9 
…nscode-sign-encrypt-files
@michaelkamphausen
installed PKIjs for using PKCS#7 and PKCS#10 and installed any-ascii …
e533597 
…for transliteration, configured both for testing it with jest;

added requirement of node >= 16 for using WebCrypto API;
installed xmldom because DOMParser was no longer available;
updated typescript and other dependencies and fixed typescript warnings and errors
@michaelkamphausen
added transliteration methods
14cc238
@michaelkamphausen
methods for signing and encrypting payload files as well as generatin…
1bc4fd1 
…g certification requests
@michaelkamphausen
added methods to group, validate and prepare transmissions of invoices
d7d38ea
@michaelkamphausen
create files for transmission with example data to perform a test pro…
d4c80c1 
…cedure
@michaelkamphausen
ensure https is used for every request to improve security
8fafca2
@michaelkamphausen
Kostenträger RSS feed sometimes contains URLs to additional files lik…
3cc2e4e 
…e PDF that are no Kostenträger files and which should not be handled and parsed
@michaelkamphausen
Merge branch 'main' into feat/transcode-sign-encrypt-files
1cc8de4 
# Conflicts:
#	src/sgb-xi/index.ts
#	src/sgb-xi/segments.ts
#	src/sgb-xi/validation.ts
@michaelkamphausen michaelkamphausen marked this pull request as ready for review December 1, 2021 16:36
@michaelkamphausen
Copy link
Member Author

This PR includes the grouping (by recipient), signature, encryption, transliteration and transcoding of Nutzdaten for transmission. It's grown into a rather large PR.

Are you interested in reviewing it?

@westnordost
Copy link
Contributor

Yes, I will

@westnordost
Copy link
Contributor

okay, it's a lot... do you prefer one complete review with many comments that will take some time or do you prefer several smaller incomplete reviews?

@michaelkamphausen
Copy link
Member Author

Thank you!

Good question. I think the simpler, less time-consuming approach is appropriate. So that would be several smaller incomplete reviews, I assume?

@westnordost
Copy link
Contributor

Yes

westnordost
westnordost reviewed Dec 3, 2021
View reviewed changes
Copy link
Contributor

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, here is the first batch of comments. All relatively minor things I think and no mistakes or anything. At most, the duplicate PKI related dependencies could constitute a theoretical vulnerability (because the more deps, the higher the risk).

I mostly looked at files where you made only small changes and the PKI stuff and avoided the really big things because I am a lazy ass and just wanted to get this counter up ;-P
image

Once you resolved (or tapped on "resolve") all the comments, just tap the button to re-request a review and I'll have the next look.

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
src/kostentraeger/index.ts Show resolved Hide resolved
src/sgb-v/filenames.ts Outdated Show resolved Hide resolved
src/sgb-xi/filenames.ts Outdated Show resolved Hide resolved
src/pki/crypto.ts Show resolved Hide resolved
src/pki/pkcs.ts Show resolved Hide resolved
src/pki/pkcs.ts Show resolved Hide resolved
src/pki/validation.ts Show resolved Hide resolved
src/pki/validation.ts Show resolved Hide resolved
@westnordost
Copy link
Contributor

Btw. in the interest of time efficiency, I suggest that if you think for any one thing "nah, it's fine", just hit the "resolve conversation" button without further explanation.

michaelkamphausen and others added 5 commits December 6, 2021 08:00
@michaelkamphausen @westnordost
documentation
1f12b31 
Co-authored-by: Tobias Zwick <newton@openclonk.org>
@michaelkamphausen @westnordost
documentation
ab4c432 
Co-authored-by: Tobias Zwick <newton@openclonk.org>
@michaelkamphausen
documentation
0b90f45
@michaelkamphausen
code style
acfaa93
@michaelkamphausen
fixed test
6c7226c
westnordost
westnordost reviewed Dec 6, 2021
View reviewed changes
Copy link
Contributor

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will need to set aside some more time to get to the core of this PR (SGBXI message creation). For now, some more comments on various smaller things

src/pki/crypto.ts Show resolved Hide resolved
src/transcoding/din66003drv.ts Show resolved Hide resolved
src/transmission/email.ts Show resolved Hide resolved
src/transmission/email.ts Show resolved Hide resolved
src/transmission/email.ts Show resolved Hide resolved
tests/transcoding/index.spec.ts Show resolved Hide resolved
@michaelkamphausen @westnordost
documentation
8e2672b 
Co-authored-by: Tobias Zwick <newton@openclonk.org>
westnordost
westnordost reviewed Dec 14, 2021
View reviewed changes
Copy link
Contributor

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allright, review done. I noticed that much of the bigger-seeming stuff was just moving code around from index.ts to calculation.ts and message.ts etc.

I also didn't look at the tests but just the code.

src/types.ts Outdated Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
src/sgb-xi/calculation.ts Outdated Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
@michaelkamphausen
Copy link
Member Author

Thank you so much for taking the time to review!

@michaelkamphausen michaelkamphausen merged commit 997abb2 into main Dec 15, 2021
@michaelkamphausen michaelkamphausen deleted the feat/transcode-sign-encrypt-files branch December 15, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westnordost westnordost westnordost left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split invoice data by receiver for separate Nutzdaten files
2 participants
@michaelkamphausen @westnordost