fix: remove HTML tags from default tokens email

coopanio · Feb 23, 2023 · 68952e7 · 68952e7
1 parent 1887fdf
commit 68952e7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/app/views/consultations_mailer/default_tokens_email.text.erb b/app/views/consultations_mailer/default_tokens_email.text.erb
@@ -3,7 +3,7 @@
 <%= t('consultations_mailer.default_tokens_email.body').strip %>
 
 <% @tokens.each do |token| %>
-  - <%= t('consultations.consultation_token_created', token:, role: token.translated_role) %>
+  - <%= sanitize t('consultations.consultation_token_created', token:, role: token.translated_role), tags: [] %>
 <% end %>
 
 <%= t('application_mailer.complimentary_close', recipient: Rails.configuration.x.asembleo.title).strip %>
diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -105,8 +105,6 @@ en:
     default_tokens_email:
       subject: Tokens created for %{consultation.title}
       body: |
-        Hello,
-
         The following tokens were created:
   errors:
     bad_request: Bad request

diff --git a/test/mailers/consultations_mailer_test.rb b/test/mailers/consultations_mailer_test.rb
@@ -11,8 +11,8 @@ class ConsultationsMailerTest < ActionMailer::TestCase
 
     assert_equal [to], email.to
     assert_equal "Tokens created for #{consultation.title}", email.subject
-    assert_includes email.body.to_s, "- Admin token is <strong>#{tokens.first}</strong>."
-    assert_includes email.body.to_s, "- Manager token is <strong>#{tokens.second}</strong>."
+    assert_includes email.body.to_s, "- Admin token is #{tokens.first}."
+    assert_includes email.body.to_s, "- Manager token is #{tokens.second}."
     assert_includes email.body.to_s, "Thanks,\n#{Rails.configuration.x.asembleo.title}"
   end
 end