Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor concerns, add deface #121

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Refactor concerns, add deface #121

merged 3 commits into from
Mar 23, 2023

Conversation

microstudi
Copy link
Collaborator

@microstudi microstudi commented Mar 22, 2023

fixes #126

  • Reorganize concerns & use deface instead of overriding the whole file

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Patch coverage: 96.77% and project coverage change: +0.04 🎉

Comparison is base (ffe1fba) 98.02% compared to head (7e4f065) 98.06%.

❗ Current head 7e4f065 differs from pull request most recent head 4c097b5. Consider uploading reports for the commit 4c097b5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   98.02%   98.06%   +0.04%     
==========================================
  Files          66       68       +2     
  Lines         962      982      +20     
==========================================
+ Hits          943      963      +20     
  Misses         19       19              
Impacted Files Coverage Δ
...r/consultations/multiple_vote_question_override.rb 100.00% <ø> (ø)
..._delegator/consultations/vote_question_override.rb 94.73% <ø> (ø)
...ons/question_multiple_votes_controller_override.rb 100.00% <ø> (ø)
...onsultations/question_votes_controller_override.rb 100.00% <ø> (ø)
...ications/sms/authorizations_controller_override.rb 100.00% <ø> (ø)
...tion_delegator/consultations/vote_form_override.rb 100.00% <ø> (ø)
...im/action_delegator/consultations/vote_override.rb 100.00% <ø> (ø)
...n_delegator/consultations_permissions_extension.rb 100.00% <ø> (ø)
lib/decidim/action_delegator/version.rb 0.00% <0.00%> (ø)
...consultations/consultations_controller_override.rb 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@microstudi microstudi changed the title Remove DirectVerification dependency Refactor concerns, add deface Mar 23, 2023
@microstudi microstudi marked this pull request as ready for review March 23, 2023 09:53
@microstudi microstudi merged commit 141092b into main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize concerns & use deface instead of overriding the whole file
2 participants