Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error messages on delegation imports #160

Merged
merged 5 commits into from
May 16, 2023
Merged

Fix error messages on delegation imports #160

merged 5 commits into from
May 16, 2023

Conversation

microstudi
Copy link
Collaborator

@microstudi microstudi commented May 16, 2023

Fix misleading error messages when importing delegation via csv

@microstudi microstudi changed the base branch from main to develop May 16, 2023 09:39
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0ff204e) 98.09% compared to head (b76e7fe) 98.09%.

❗ Current head b76e7fe differs from pull request most recent head b5d4f05. Consider uploading reports for the commit b5d4f05 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #160   +/-   ##
========================================
  Coverage    98.09%   98.09%           
========================================
  Files           92       92           
  Lines         1841     1841           
========================================
  Hits          1806     1806           
  Misses          35       35           
Impacted Files Coverage Δ
...ecidim/action_delegator/admin/create_delegation.rb 96.15% <100.00%> (ø)
.../decidim/action_delegator/admin/delegation_form.rb 100.00% <100.00%> (ø)
...ecidim/action_delegator/responses_by_membership.rb 100.00% <100.00%> (ø)
...cidim/action_delegator/delegations_csv_importer.rb 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@microstudi microstudi merged commit 8878eb3 into develop May 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants