-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement weighted results display on public interface #171
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=======================================
Coverage 98.15% 98.16%
=======================================
Files 94 94
Lines 1896 1905 +9
=======================================
+ Hits 1861 1870 +9
Misses 35 35 ☔ View full report in Codecov by Sentry. |
@microstudi Ivan, this pr is ready to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very nice,
just a think, can we add the added files to the the lib/overrides_spec.rb to keep track of them?
One of them had already been added, I added the other two |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job!
fixes #170
Description:
Implemented the display of weighted voting results in the public interface, ensuring the winning option shown is the true winner based on the weighted votes. This corrects the previous issue where results didn't reflect the actual impact of certain votes.
Changes:
Screenshots: