Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement weighted results display on public interface #171

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

antopalidi
Copy link
Collaborator

@antopalidi antopalidi commented Mar 6, 2024

fixes #170

Description:

Implemented the display of weighted voting results in the public interface, ensuring the winning option shown is the true winner based on the weighted votes. This corrects the previous issue where results didn't reflect the actual impact of certain votes.

Changes:

  • Added weighted sum calculation for votes.
  • Updated public results display to reflect weighted outcomes.

Screenshots:

Screenshot 2024-03-06 at 13 26 24
Screenshot 2024-03-06 at 13 26 41

@antopalidi antopalidi self-assigned this Mar 6, 2024
@antopalidi antopalidi changed the title Display the weighted result in the public part of the questions Implement weighted results display on public interface Mar 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (504980f) to head (8f1baa6).

❗ Current head 8f1baa6 differs from pull request most recent head 0970612. Consider uploading reports for the commit 0970612 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   98.15%   98.16%           
=======================================
  Files          94       94           
  Lines        1896     1905    +9     
=======================================
+ Hits         1861     1870    +9     
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antopalidi
Copy link
Collaborator Author

@microstudi Ivan, this pr is ready to review

Copy link
Collaborator

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very nice,
just a think, can we add the added files to the the lib/overrides_spec.rb to keep track of them?

@antopalidi
Copy link
Collaborator Author

antopalidi commented Mar 8, 2024

looks very nice, just a think, can we add the added files to the the lib/overrides_spec.rb to keep track of them?

One of them had already been added, I added the other two

Copy link
Collaborator

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

@microstudi microstudi merged commit b481bde into main Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the weighted result in the public part of the questions
3 participants