Link results to custom controller #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to provide multiple languages for these tests to work so we better stick to shorter definitions, which is a bit more readable.
Without this, `decidim-consultations`'s `ConsultationsController` gets called and so `@questions` is not defined which causes our `results.html.erb` view to fail with a `ActionView::Template::Error Decidim::Consultations::Admin::ConsultationsController#results undefined method `each' for nil:NilClass`.
sauloperez
force-pushed
the
link-results-to-custom-controller
branch
from
fc35c3a
to
cf22080
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this,
decidim-consultations'sConsultationsControllergets called and so@questionsis not defined which causes ourresults.html.erbview to fail with a