Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login box #278

Closed
enricostano opened this issue Oct 31, 2017 · 15 comments · Fixed by #395
Closed

Fix login box #278

enricostano opened this issue Oct 31, 2017 · 15 comments · Fixed by #395
Assignees

Comments

@enricostano
Copy link
Contributor

2017-10-31-182416_1366x768_scrot

@enricostano
Copy link
Contributor Author

cc/ @mllocs

@mllocs
Copy link
Collaborator

mllocs commented Oct 31, 2017

what about removing that "TimeOverflow" header text? You have that name right on the top bar, quite visible already.

@enricostano
Copy link
Contributor Author

ask @sseerrggii 😬

@sauloperez
Copy link
Collaborator

Agree with @mllocs

@sseerrggii
Copy link
Contributor

Agree with @mllocs 👍 also check sizes in mobile

In my mobile resolution the input boxes (mail/password) are too big

@mllocs
Copy link
Collaborator

mllocs commented Nov 2, 2017

👍 willdo

@mllocs mllocs self-assigned this Nov 2, 2017
@Matt-Yorkley
Copy link
Contributor

It will be different for every screen, no? I think the css positioning for the devise modal needs to be rethought, instead of just cutting off the header text.

screenshot from 2018-01-08 00-19-12

@sauloperez
Copy link
Collaborator

It's just that the modal should always fall below the nav bar, and without title, right?

@Matt-Yorkley
Copy link
Contributor

Agreed. Currently it seems to move up or down depending on how large it is.

@sauloperez
Copy link
Collaborator

Now that we merged #282 this seems like a good follow-up. Still interested @Matt-Yorkley ?

@juanjochi
Copy link

I do not know if it will work but I changed the container size of 500px and put it to 649px and it seems that the whole box looks good, I put the screens.
captura de pantalla_2018-03-09_14-23-26
captura de pantalla_2018-03-09_14-23-57
captura de pantalla_2018-03-09_14-25-34

@markets
Copy link
Collaborator

markets commented Jun 21, 2018

@enricostano @mllocs @sauloperez 👋 Maybe we can consider this as done by #375?

@Matt-Yorkley
Copy link
Contributor

Looks like this issue can't be closed yet:
screenshot from 2018-06-21 23-33-31

@markets
Copy link
Collaborator

markets commented Jun 21, 2018

Right @Matt-Yorkley! Thanks for looking into this 👍

@enricostano
Copy link
Contributor Author

enricostano commented Aug 8, 2018

2018-08-08-135859_1366x768_scrot

This is how I see it with the most recent develop. cc/ @mllocs @Matt-Yorkley @markets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants