Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed login vertical alignment #395

Merged
merged 1 commit into from Aug 22, 2018
Merged

Conversation

mllocs
Copy link
Collaborator

@mllocs mllocs commented Aug 8, 2018

Should fix #278

Improved the way we position the login box. Now it is vertically centered, so it plays better in screens that are not very high.

http://g.recordit.co/rfv6n3arfF.gif

@mllocs mllocs requested a review from enricostano August 8, 2018 15:02
@sseerrggii
Copy link
Contributor

I noticed this problem

peek 16-08-2018 11-48

@mllocs mllocs force-pushed the fix/login-vertical-alignment branch from a70982c to 3065aa8 Compare August 21, 2018 16:20
@mllocs
Copy link
Collaborator Author

mllocs commented Aug 21, 2018

@sseerrggii good catch! Ja ho he arreglat, ready to test it again 💪

@enricostano
Copy link
Contributor

Testing in staging:

screen shot 2018-08-22 at 14 36 24

cc/ @mllocs

@enricostano
Copy link
Contributor

Talked offline with @mllocs , it works fine for now. Merging.

@enricostano enricostano merged commit c75da2d into develop Aug 22, 2018
@enricostano enricostano deleted the fix/login-vertical-alignment branch August 22, 2018 14:16
@enricostano enricostano mentioned this pull request Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix login box
4 participants