-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize code structure #52
Merged
gallego-posada
merged 17 commits into
dev
from
gallego-posada/48-modularize-code-structure
Oct 24, 2022
Merged
Modularize code structure #52
gallego-posada
merged 17 commits into
dev
from
gallego-posada/48-modularize-code-structure
Oct 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com:cooper-org/cooper into gallego-posada/48-modularize-code-structure
juan43ramirez
approved these changes
Oct 24, 2022
This was referenced Oct 24, 2022
This was referenced Mar 21, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48
Changes
ConstrainedMinimizationProblem (CMP)
is_constrained
argument/attribute from CMP.is_constrained
has been refactored inside eachCooperOptimizer
subclass (see below).Constrained Optimizer
CooperOptimizer
class.SimultaneousConstrainedOptimizer
,AlternatingConstrainedOptimizer
,ExtrapolationConstrainedOptimizer
.UnconstrainedOptimizer
for wrapping (primal) optimizers when dealing with unconstrained problems.ConstrainedOptimizer
subclass.ConstrainedOptimizer
class, and makes maintaining the code for the individual optimizers simpler.cooper.optim.constrained_optimizers.utils.create_optimizer_from_kwargs
so users can conveniently create the "right" optimizer class based on their choice of alternating/extrapolation/etc.cooper.optim.constrained_optimizers.cooper_optimizer.CooperOptimizerState
dataclass for storing the state of primal and dual optimizers, and other configurations of aCooperOptimizer
object.Formulation
formulation
Multipliers
multipliers