Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.import_ngs_data() HTTPError when filtering for year(s) #26

Closed
jbf302 opened this issue Jul 26, 2022 · 2 comments
Closed

.import_ngs_data() HTTPError when filtering for year(s) #26

jbf302 opened this issue Jul 26, 2022 · 2 comments

Comments

@jbf302
Copy link

jbf302 commented Jul 26, 2022

HTTPError: HTTP Error 404: Not Found

I receive a 404: not found error when I try to import ngs data from a specific year:

This works just fine and returns the dataframe:

ngs_data = nfl.import_ngs_data('passing')

ngs_data

When I add a specific year argument, this breaks:

ngs_data = nfl.import_ngs_data('passing', [2020])

ngs_data

Yes: I realize that nfl.import_ngs_data('passing') is comprehensive of all seasons that are available and I can filter with that.

I don't know much about these different file formats, but when I look in nflverse-data/releases/nextgen_stats it looks like there are no .parquet files specific to a season (only .qs, .csv.gz, .rds), only the larger ones (sans season) called in the first block:
Screen Shot 2022-07-26 at 12 12 50 PM

So I think something just needs to be changed around here?

Thanks for putting together this awesome library!! It's been a huge help as I get ready for the season.

@cooperdff
Copy link
Collaborator

Thanks for flagging this - the nflverse folks did a little rearranging of their data and it must've made that logic defunct. I'll get it sorted out this weekend.

@cooperdff
Copy link
Collaborator

Fixed in v0.2.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants