Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID Tables Small Issue? #27

Closed
robertryanharrison opened this issue Aug 5, 2022 · 2 comments
Closed

ID Tables Small Issue? #27

robertryanharrison opened this issue Aug 5, 2022 · 2 comments

Comments

@robertryanharrison
Copy link

Hi, i'm a newb and this is my first issue post so please delete if this is wrong. I suspect your code is fine and that the source data has some bugs, but i'm not sure who to alert to help them out.

I believe there are some slight data issues on the player ID table.

probably some more than listed below, but i have to run for now. these are pretty small things, doubtful they will be relevant to anything imminent for anyone... i ran into it on a merge i was doing on gsis_id that didn't like my many-to-one relationship because of it. i'm happy to share and/or try to help fix if manual edits are an option (i stink at coding though)

gsis_id has four duplications: 00-0020270, 00-0019641, 00-0016098, and 00-0029435.
On further research, each of these same cases also has a duplication of the pff_id.
There are no other pff_id duplications.

espn_ids have some duplication: 17257, 2578554, 2574009, 5774, 5730, 12771, 2516049, 13490, 2574010, 14660, 2582138, 16094, 17101. i'm not sure the source of all of these - some seem to be extremely similar names but different people and others seem to be typos (e.g. 5774 one of them should simply be 15774).

yahoo_ids have one dup: 33495. the one from Duke should be 33542

@alecglen
Copy link
Collaborator

alecglen commented Aug 5, 2022

Welcome to the club, @robertryanharrison!

You're correct that it's an issue in the source data. In this case that is sourced from a CSV over here - could you please make an issue in that project?

@robertryanharrison
Copy link
Author

Yes! Will do, thanks for pointing me in the right direction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants